Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql-api): ability to extend connection information #988

Merged
merged 1 commit into from
May 25, 2020

Conversation

pradel
Copy link
Member

@pradel pradel commented May 25, 2020

The goal of this pr is to provide a way for the user to extends the info object that will be passed down to the server functions from the GraphQL context.
I will create another pr adding this for REST too.

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #988 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #988   +/-   ##
=======================================
  Coverage   95.19%   95.20%           
=======================================
  Files          80       80           
  Lines        1791     1792    +1     
  Branches      387      387           
=======================================
+ Hits         1705     1706    +1     
  Misses         84       84           
  Partials        2        2           
Impacted Files Coverage Δ
...rc/modules/accounts-password/resolvers/mutation.ts 100.00% <100.00%> (ø)
packages/graphql-api/src/modules/accounts/index.ts 76.00% <100.00%> (ø)
...hql-api/src/modules/accounts/resolvers/mutation.ts 93.33% <100.00%> (ø)
packages/graphql-api/src/utils/context-builder.ts 94.73% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956b2c6...e89aa00. Read the comment docs.

@pradel pradel merged commit 853afaa into master May 25, 2020
@pradel pradel deleted the feature/extend-connection-information branch May 25, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant