docs: fix missing await in getting started #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You where calling `.listen` on the promise. other option would've been `await (await accountsBoost(...)).listen`, but I figured that could be a bit confusing.
Codecov Report
@@ Coverage Diff @@
## master #998 +/- ##
=======================================
Coverage 95.22% 95.22%
=======================================
Files 80 80
Lines 1802 1802
Branches 389 389
=======================================
Hits 1716 1716
Misses 84 84
Partials 2 2 Continue to review full report at Codecov.
|
pradel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You where calling
.listenon the promise.other option would've been
await (await accountsBoost(...)).listen,but I figured that could be a bit confusing.