Open_Application does not always start app with webdriver

[mengelskirchen]

Issue

DesktopLibrary#open_application does not start the app with webdriver#remote when the attribute window_name is given.

The result is that the application may be started with an other user than webdriver is running with and as it with other user rights than intended.

robotframework-zoomba/src/Zoomba/DesktopLibrary.py

Lines 280 to 299 in 69012dd

	if window_name:
	# If the app has a splash screen we need to supply the window_name of the final window.
	# This code path will start the application and then attach to the correct window via
	# the window_name.
	self._info('Opening application "%s"' % desired_caps['app'])
	subprocess.Popen(desired_caps['app'])
	if splash_delay > 0:
	self._info('Waiting %s seconds for splash screen' % splash_delay)
	sleep(splash_delay)
	return self.switch_application_by_name(remote_url, alias=alias, window_name=window_name,
	exact_match=exact_match, desktop_alias=desktop_alias, **kwargs)
	# global application
	self._open_desktop_session(remote_url, desktop_alias)
	if "platformName" not in desired_caps:
	desired_caps["platformName"] = "Windows"
	if "forceMjsonwp" not in desired_caps:
	desired_caps["forceMjsonwp"] = True
	application = webdriver.Remote(str(remote_url), desired_caps)
	self._debug('Opened application with session id %s' % application.session_id)
	return self._cache.register(application, alias)

[Wolfe1]

While I agree that what you have here is cleaner I believe there was a reason I went with subprocess before. I think it had to do with Webdriver.Remote failing after the splash screen disappears.

I will take a look on my end though with some internal tests with splash screens sometime this week.

Thanks!