Merge pull request #258 from accurics/terrascan-v1.0-test-codecov-pr-…

…comments

add unit tests for cloud-provider package

pkg/cloud-providers/cloud-provider.go

@@ -7,14 +7,18 @@ import (
 	"go.uber.org/zap"
 )
 
+var (
+	errCloudNotSupported = fmt.Errorf("cloud type not supported")
+)
+
 // NewCloudProvider returns a new CloudProvider
 func NewCloudProvider(cloudType string) (cloudProvider CloudProvider, err error) {
 
 	// get CloudProvider from supportedCloudProviders
 	cloudProviderObject, supported := supportedCloudProviders[supportedCloudType(cloudType)]
 	if !supported {
 		zap.S().Errorf("cloud type '%s' not supported", cloudType)
-		return cloudProvider, fmt.Errorf("cloud type not supported")
+		return cloudProvider, errCloudNotSupported
 	}
 
 	return reflect.New(cloudProviderObject).Interface().(CloudProvider), nil

pkg/cloud-providers/providers_test.go

@@ -0,0 +1,72 @@
+package cloudprovider
+
+import (
+	"reflect"
+	"testing"
+
+	awsProvider "github.com/accurics/terrascan/pkg/cloud-providers/aws"
+)
+
+func TestNewCloudProvider(t *testing.T) {
+
+	table := []struct {
+		name      string
+		cloudType supportedCloudType
+		want      CloudProvider
+		wantErr   error
+	}{
+		{
+			name:      "aws provider",
+			cloudType: aws,
+			want:      &awsProvider.AWSProvider{},
+			wantErr:   nil,
+		},
+		{
+			name:      "not supported cloud type",
+			cloudType: "not-supported",
+			want:      nil,
+			wantErr:   errCloudNotSupported,
+		},
+	}
+
+	for _, tt := range table {
+		t.Run(tt.name, func(t *testing.T) {
+			got, gotErr := NewCloudProvider(string(tt.cloudType))
+			if !reflect.DeepEqual(gotErr, tt.wantErr) {
+				t.Errorf("unexpected error; gotErr: '%v', wantErr: '%v'", gotErr, tt.wantErr)
+			}
+			if !reflect.DeepEqual(got, tt.want) {
+				t.Errorf("got: '%v', want: '%v'", got, tt.want)
+			}
+		})
+	}
+}
+
+func TestIsCloudSupported(t *testing.T) {
+
+	table := []struct {
+		name      string
+		cloudType supportedCloudType
+		want      bool
+	}{
+		{
+			name:      "aws provider",
+			cloudType: aws,
+			want:      true,
+		},
+		{
+			name:      "not supported cloud type",
+			cloudType: "not-supported",
+			want:      false,
+		},
+	}
+
+	for _, tt := range table {
+		t.Run(tt.name, func(t *testing.T) {
+			got := IsCloudSupported(string(tt.cloudType))
+			if got != tt.want {
+				t.Errorf("got: '%v', want: '%v'", got, tt.want)
+			}
+		})
+	}
+}