Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS.CloudFront.Network Security.Low.0568 Doesn't allow skipping due to space in filename #549

Closed
brainthee opened this issue Feb 16, 2021 · 3 comments · Fixed by #845
Closed
Assignees
Labels
bug policy Issue concerning policy maintainers.

Comments

@brainthee
Copy link

  • terrascan version: v1.3.1
  • Operating System: Ubuntu 20.10

Description

When defining a aws_cloudfront_distribution resource, one of the policies can not be skipped due to a space in it's filename (and therefore I assume failing the regex check for the #ts lines).

What I Did

We have a aws_cloudfront_distribution resource that defines no geo restrictions as restrictions are handled further down the chain:

  restrictions {
    geo_restriction {
      restriction_type = "none"
    }
  }

So the policy failing is correct, we just can't skip it due to the space in the file here: https://github.com/accurics/terrascan/blob/master/pkg/policies/opa/rego/aws/aws_cloudfront_distribution/AWS.CloudFront.Network%20Security.Low.0568.json

@amirbenv
Copy link
Contributor

Thanks for reporting. We'll get it fixed soon!

@jerusdp
Copy link

jerusdp commented Mar 1, 2021

Similar problem in aws.api.gateway.stage set with space in the file name for the JSON files.

@harkirat22
Copy link
Contributor

@jerusdp thanks for reporting. Going to get it fixed

@kanchwala-yusuf kanchwala-yusuf added the policy Issue concerning policy maintainers. label May 11, 2021
@gaurav-gogia gaurav-gogia linked a pull request Jun 9, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug policy Issue concerning policy maintainers.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants