Accept notification webhook configs as CLI args #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasir-rabbani
requested review from
patilpankaj212,
kanchwala-yusuf and
Rchanger
Codecov Report
@@ Coverage Diff @@
## master #1042 +/- ##
==========================================
+ Coverage 78.32% 78.57% +0.24%
==========================================
Files 238 238
Lines 6459 6477 +18
==========================================
+ Hits 5059 5089 +30
+ Misses 1091 1075 -16
- Partials 309 313 +4
|
nasir-rabbani
force-pushed
the
feature-webhook-args
branch
from
f7cce6a
to
8bc127a
Compare
nasir-rabbani
force-pushed
the
feature-webhook-args
branch
from
8bc127a
to
6bb2cff
Compare
cesar-rodriguez
changed the title
|
Hey @nasir-rabbani , would it be possible to add e2e or integration test for this feature? |
nasir-rabbani
force-pushed
the
feature-webhook-args
branch
from
d67309a
to
b45a25a
Compare
cesar-rodriguez
suggested changes
Oct 18, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
cesar-rodriguez
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will allow us to accept notification web hook config values as
CLI argsand asform datain Server Mode.