Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Docker buildx for multi-platform support #1062

Merged
merged 5 commits into from Apr 7, 2022

Conversation

rnsc
Copy link
Contributor

@rnsc rnsc commented Oct 19, 2021

This PR should solve #1061.
Hopefully this can be built within your current pipeline (referring to my first commit).

@rnsc
Copy link
Contributor Author

rnsc commented Oct 19, 2021

@cesar-rodriguez hopefully this tiny commit should be enough to build a multi platform image

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #1062 (dab35ab) into master (471df8b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1062   +/-   ##
=======================================
  Coverage   77.73%   77.73%           
=======================================
  Files         272      272           
  Lines        7683     7683           
=======================================
  Hits         5972     5972           
  Misses       1357     1357           
  Partials      354      354           

@cesar-rodriguez
Copy link
Contributor

@rnsc I modified the workflow so we can test that this works before merging, but there seems to be an issue with the driver: https://github.com/accurics/terrascan/pull/1062/checks?check_run_id=3952337701

@rnsc
Copy link
Contributor Author

rnsc commented Oct 20, 2021

Hey @cesar-rodriguez thank you for this!
That's weird, I'm using buildx (albeit "natively" in workflows) myself without issues on GitHub hosted instances:
https://github.com/rnsc/dockerfiles/blob/githubactions-docker-build/.github/workflows/debian.yml

I'll have a deeper look to see if I'm missing anything.

@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rnsc
Copy link
Contributor Author

rnsc commented Oct 21, 2021

@cesar-rodriguez I've also noticed that there's an "amd64" value set in the Dockerfile, I'll need to investigate that too, not as trivial of a change as I thought!

@rnsc rnsc requested review from a team and bkizer-tenable as code owners April 7, 2022 10:27
@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cesar-rodriguez cesar-rodriguez merged commit e3153a1 into tenable:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants