Fix Sarif file uri path invalid in Windows and update go-sarif to latest #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1070 +/- ##
==========================================
- Coverage 78.62% 78.59% -0.04%
==========================================
Files 238 238
Lines 6494 6502 +8
==========================================
+ Hits 5106 5110 +4
- Misses 1075 1077 +2
- Partials 313 315 +2
|
shaopeng-gh
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
@kanchwala-yusuf let me know if looks good, thanks! |
|
@cesar-rodriguez @kanchwala-yusuf let me know if anyone can help with the review, thanks! |
cesar-rodriguez
approved these changes
Dec 10, 2021
|
@shaopeng-gh thanks again for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The locations should conform with https://tools.ietf.org/html/rfc3986,
we currently get "file://C:\\reporoot\\input\\azuredeploy.json" in windows
in Linux it is correct for me, "file:///home/lsp/terrascan/input/azuredeploy.json"
The correct uri path for Windows should be like "file:///C:/reporoot/input/azuredeploy.json"