Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/eks msk vpc version #1140

Merged

Conversation

gaurav-gogia
Copy link
Contributor

Add support for the following resources:

  1. EKS Cluster
  2. EC2 VPC

Update support for:

  1. MSK Cluster
  2. ECR Repository

Update goformation library version to use the latest one

@sonarcloud
Copy link

sonarcloud bot commented Feb 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #1140 (f425f56) into master (4dae7e4) will decrease coverage by 0.18%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1140      +/-   ##
==========================================
- Coverage   79.45%   79.26%   -0.19%     
==========================================
  Files         253      255       +2     
  Lines        7059     7091      +32     
==========================================
+ Hits         5609     5621      +12     
- Misses       1116     1136      +20     
  Partials      334      334              
Impacted Files Coverage Δ
pkg/iac-providers/cft/v1/load-file.go 79.54% <ø> (ø)
pkg/iac-providers/cft/v1/sanitize-cft-template.go 83.65% <ø> (ø)
...r/iac-providers/cft/config/api-gateway-rest-api.go 100.00% <ø> (ø)
...pper/iac-providers/cft/config/api-gateway-stage.go 84.37% <ø> (ø)
...er/iac-providers/cft/config/api-gatewayv2-stage.go 100.00% <ø> (ø)
...ers/cft/config/autoscaling-launch-configuration.go 85.71% <ø> (ø)
...iders/cft/config/certificatemanager-certificate.go 100.00% <ø> (ø)
...r/iac-providers/cft/config/cloudformation-stack.go 88.23% <ø> (ø)
...ac-providers/cft/config/cloudfront-distribution.go 100.00% <ø> (ø)
pkg/mapper/iac-providers/cft/config/cloudtrail.go 50.00% <ø> (ø)
... and 54 more

Copy link
Contributor

@nasir-rabbani nasir-rabbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from few Exported types everything else LGTM

Copy link
Contributor

@Rchanger Rchanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaurav-gogia gaurav-gogia merged commit 575bff2 into tenable:master Feb 7, 2022
@gaurav-gogia gaurav-gogia deleted the feature/eks-msk-vpc-version branch February 8, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants