Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backward compatible implementation of AC_AWS_0214 #1173

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

HorizonNet
Copy link
Contributor

Add a backward compatible implementation of AC_AWS_0214, which also
works for provider versions before 4.0.0.

It was tested based on the example in #1172 and returns the following result

Scan Summary -

    File/Folder         :   main.tf
    IaC Type            :   terraform
    Scanned At          :   2022-02-27 15:01:56.298085 +0000 UTC
    Policies Validated  :   14
    Violated Policies   :   0
    Low                 :   0
    Medium              :   0
    High                :   0

Resolves #1172

Add a backward compatible implementation of AC_AWS_0214, which also
works for provider versions before 4.0.0.

Resolves #1172
@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #1173 (776f63f) into master (21a7384) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1173   +/-   ##
=======================================
  Coverage   78.32%   78.32%           
=======================================
  Files         271      271           
  Lines        7452     7452           
=======================================
  Hits         5837     5837           
  Misses       1280     1280           
  Partials      335      335           

@harkirat22 harkirat22 self-requested a review February 28, 2022 01:25
Copy link
Contributor

@harkirat22 harkirat22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this issue.

@harkirat22 harkirat22 merged commit 504aa1a into tenable:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AC_AWS_0214 not backward compatible
2 participants