fix template rendering bug #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
williepaul
commented
Sep 10, 2020
williepaul
commented
- templates were only being rendered once per file, rather than once per rule
- thus, the first render for each file would win, and violations could trigger (or be missed) if using a shared template
- templates were only being rendered once per file, rather than once per rule - thus, the first render for each file would win, and violations could trigger (or be missed) if using a shared template
williepaul
requested review from
cesar-rodriguez,
harshitAccurics and
kanchwala-yusuf
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
=======================================
Coverage 59.36% 59.36%
=======================================
Files 48 48
Lines 982 982
=======================================
Hits 583 583
Misses 350 350
Partials 49 49
|
cesar-rodriguez
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.