Adds support for Helm v3 #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
==========================================
+ Coverage 64.26% 65.90% +1.63%
==========================================
Files 76 80 +4
Lines 1679 1830 +151
==========================================
+ Hits 1079 1206 +127
- Misses 505 521 +16
- Partials 95 103 +8
|
added 6 commits
November 11, 2020 16:14
- supports loading of helm v3 charts via the iac dir command (iac file is invalid) - adds default iac versions for all iac types - adds unit tests - adds ability to properly specify default iac version for a given iac type
- make sure empty directories are created by adding a placeholder file
- avoids some repeated strings by using logger.With() - move rendering code into a separate function - remove a duplicate test - add more comments
- try #2 with cognitive complexity by moving for loop outside of the render func - update error level of some log messages
- adds .yml to the valid list of chart yamls - default to 1 instead of 0 for source line in the helm_chart resource - TODO: add values.yml support for rancher
- Chart.yml is used by rancher, but we would likely support rancher in a separate iac type, so removing from helm
williepaul
force-pushed
the
add-helm-support
branch
from
079c962
to
9385d11
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
cesar-rodriguez
approved these changes
Nov 12, 2020
kanchwala-yusuf
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #353