Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes GCP cos node image policy #397

Merged
merged 2 commits into from
Nov 20, 2020

Conversation

cesar-rodriguez
Copy link
Contributor

Fixes an issue where the cos_containerd was being flagged as not compliant with the accurics.gcp.OPS.114 policy.

Resolves #395

@cesar-rodriguez cesar-rodriguez changed the title Fxes GCP cos node image policy Fixes GCP cos node image policy Nov 20, 2020
@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #397 (91b5923) into master (6a24967) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #397   +/-   ##
=======================================
  Coverage   63.55%   63.55%           
=======================================
  Files          85       85           
  Lines        1904     1904           
=======================================
  Hits         1210     1210           
  Misses        591      591           
  Partials      103      103           

@sonarcloud
Copy link

sonarcloud bot commented Nov 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@williepaul
Copy link
Contributor

Hey Cesar, I tried this, and I believe the logic is backwards. It should not have a "not" clause; the last line should just read startswith(node.image_type, "cos")

@williepaul
Copy link
Contributor

Hey Cesar, I tried this, and I believe the logic is backwards. It should not have a "not" clause; the last line should just read startswith(node.image_type, "cos")

Disregard, my test data was backwards :)

@williepaul williepaul merged commit d37fb58 into tenable:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accurics.gcp.OPS.114 should also check for cos_containerd image
3 participants