scan command refactor #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
patilpankaj212
commented
Dec 21, 2020
patilpankaj212
commented
- refactor code for scan command
- more testability for scan command
- modified existing tests for Run func
2. add new tests for Run
2. fix code smells
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
==========================================
+ Coverage 67.06% 73.39% +6.33%
==========================================
Files 86 86
Lines 1949 1962 +13
==========================================
+ Hits 1307 1440 +133
+ Misses 524 388 -136
- Partials 118 134 +16
|
pkg/cli/scan.go
Outdated
| // Verbose indicates whether to display all fields in default human readlbe output | ||
| Verbose bool | ||
| ) | ||
| var scanOptions = new(ScanOptions) |
There was a problem hiding this comment.
Can have a function like NewScanOptions() which returns a new empty *ScanOptions struct?
There was a problem hiding this comment.
I did not add any constructor function for ScanOptions struct because we are not doing any initialisation based on parameters.
williepaul
reviewed
Dec 21, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
kanchwala-yusuf
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.