recognize metadata.generateName #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
==========================================
+ Coverage 74.69% 74.73% +0.03%
==========================================
Files 88 88
Lines 2039 2042 +3
==========================================
+ Hits 1523 1526 +3
Misses 382 382
Partials 134 134
|
|
The duplicate code doesn't look like an issue to me - it looks like it's mainly the expected result from unit tests. I guess you could try to define that as a struct and then change the bits for each test, but that seems like over-engineering... |
|
SonarCloud has a different mode for analyzing source vs test files, will check how to configure that. |
williepaul
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described at https://kubernetes.io/docs/reference/using-api/api-concepts/#generated-values, the metadata.name may sometimes be generated based on metadata.generateName. Dynamically generated names are populated with unique values at runtime, meaning that metadata.name might be empty when Terrascan is run. This change uses the value of metadata.generateName for the name when metadata.name is empty. This can help, for example, with CRDs that rely on generateName.