Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme for v1.3.2 #534

Merged
merged 1 commit into from
Feb 3, 2021
Merged

update readme for v1.3.2 #534

merged 1 commit into from
Feb 3, 2021

Conversation

devang-gaur
Copy link
Contributor

No description provided.

@devang-gaur devang-gaur requested a review from jlk February 3, 2021 22:17
@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@devang-gaur devang-gaur changed the title updated readme for v1.3.2 update readme for v1.3.2 Feb 3, 2021
@@ -27,7 +27,7 @@ Terrascan's supports multiple ways to install, including [brew](https://github.c
Here, we will download the terrascan binary directly from the [releases](https://github.com/accurics/terrascan/releases) page. Make sure to select the right binary for your machine. Here's an example of how to install it:

```sh
$ curl --location https://github.com/accurics/terrascan/releases/download/v1.3.1/terrascan_1.3.1_Darwin_x86_64.tar.gz --output terrascan.tar.gz
$ curl --location https://github.com/accurics/terrascan/releases/download/v1.3.2/terrascan_1.3.2_Darwin_x86_64.tar.gz --output terrascan.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but do we need --location on curl?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't hurt being explicit in such commands, eh?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait atleast this long ass command would be shortened.

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #534 (82dc401) into master (fed8436) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   75.34%   75.34%           
=======================================
  Files          94       94           
  Lines        2235     2235           
=======================================
  Hits         1684     1684           
  Misses        408      408           
  Partials      143      143           

@jlk jlk merged commit f14d608 into tenable:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants