fix the 'repo already exist' bug and improve error logging for terrascan init #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
==========================================
- Coverage 76.98% 76.98% -0.01%
==========================================
Files 98 98
Lines 2364 2368 +4
==========================================
+ Hits 1820 1823 +3
+ Misses 404 402 -2
- Partials 140 143 +3
|
kanchwala-yusuf
suggested changes
Feb 17, 2021
pkg/initialize/run.go
Outdated
| @@ -61,6 +61,12 @@ func DownloadPolicies() error { | |||
|
|
|||
| tempPath := filepath.Join(os.TempDir(), "terrascan") | |||
There was a problem hiding this comment.
Hey @dev-gaur,
Would it make sense to use ioutil.TempDir() instead of os.TempDir()
There was a problem hiding this comment.
changes made. PTAL again
devang-gaur
force-pushed
the
fix_terrascan_init
branch
from
317328b
to
b24b89b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
kanchwala-yusuf
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a part of #551