Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix - terraform complex variables are not getting resolved #657

Merged
merged 1 commit into from Apr 13, 2021
Merged

fix - terraform complex variables are not getting resolved #657

merged 1 commit into from Apr 13, 2021

Conversation

patilpankaj212
Copy link
Contributor

@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #657 (5dcb14f) into master (5abf9af) will decrease coverage by 0.21%.
The diff coverage is 53.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
- Coverage   75.34%   75.13%   -0.22%     
==========================================
  Files         110      110              
  Lines        3014     3028      +14     
==========================================
+ Hits         2271     2275       +4     
- Misses        574      582       +8     
- Partials      169      171       +2
Impacted Files Coverage Δ
...c-providers/terraform/commons/module-references.go 42.10% <0.00%> (-4.96%) ⬇️
.../iac-providers/terraform/commons/cty-converters.go 80.00% <76.47%> (-10.25%) ⬇️
...providers/terraform/commons/variable-references.go 81.96% <80.00%> (+0.30%) ⬆️

kanchwala-yusuf
kanchwala-yusuf reviewed Apr 13, 2021
View reviewed changes
pkg/iac-providers/terraform/commons/cty-converters_test.go
args: args{
ctyVal: stringCtyVal,
},
want: "Peter Parker",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the reference here :)

kanchwala-yusuf
kanchwala-yusuf approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@kanchwala-yusuf kanchwala-yusuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kanchwala-yusuf kanchwala-yusuf merged commit 9baf154 into tenable:master Apr 13, 2021
@patilpankaj212 patilpankaj212 deleted the resolve-complex-types branch May 5, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanchwala-yusuf kanchwala-yusuf kanchwala-yusuf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

terrascan doesn't resolve terraform complex variables
2 participants
@patilpankaj212 @kanchwala-yusuf