changes for argocd integration #724
Conversation
patilpankaj212
commented
May 3, 2021
patilpankaj212
commented
- modify Dockerfile to add a folder .ssh in /home/terrascan. This folder will be used to place ssh keys, ssh config and known_hosts required for api server to download repositories.
- modify the resources skipping for kubernetes
- modify response code of api server's remote repo scan response, when the result contains admission controller denied violations.
patilpankaj212
force-pushed
the
argocd-integration-changes
branch
from
e76cea4
to
8bb60a2
Compare
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
==========================================
- Coverage 73.86% 73.18% -0.69%
==========================================
Files 110 110
Lines 3176 3170 -6
==========================================
- Hits 2346 2320 -26
- Misses 652 668 +16
- Partials 178 182 +4
|
| skipRules := make([]output.SkipRule, 0) | ||
| err := json.Unmarshal([]byte(rules), &skipRules) | ||
| if err != nil { | ||
| zap.S().Debugf("terrascanSkip rules '%s' cannot be unmarshalled to json", rules) |
There was a problem hiding this comment.
| zap.S().Debugf("terrascanSkip rules '%s' cannot be unmarshalled to json", rules) | |
| zap.S().Debugf("json string %s cannot be unmarshalled to [ ]output.SkipRules struct schema", rules) |
There was a problem hiding this comment.
Devang's comment is technically accurate, but not sure if that much detail would be useful to average user, or confusing?
There was a problem hiding this comment.
I agree with @jlk. This change will not be informative to most users.
There was a problem hiding this comment.
Debug is also used by us developers.. to diagnose what went wrong. Will ease it for us to help people reporting bugs and other issues.
| skipRules := make([]output.SkipRule, 0) | ||
| err := json.Unmarshal([]byte(rules), &skipRules) | ||
| if err != nil { | ||
| zap.S().Debugf("terrascanSkip rules '%s' cannot be unmarshalled to json", rules) |
There was a problem hiding this comment.
Devang's comment is technically accurate, but not sure if that much detail would be useful to average user, or confusing?
|
Kudos, SonarCloud Quality Gate passed!
|
