Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a kustomize based guide for setting up terrascan server and validating webhook in kubernetes #739

Merged
merged 21 commits into from
May 18, 2021

Conversation

devang-gaur
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #739 (d0679d9) into master (d242c2e) will increase coverage by 1.70%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #739      +/-   ##
==========================================
+ Coverage   73.18%   74.88%   +1.70%     
==========================================
  Files         110      110              
  Lines        3170     3309     +139     
==========================================
+ Hits         2320     2478     +158     
+ Misses        668      646      -22     
- Partials      182      185       +3     
Impacted Files Coverage Δ
...ac-providers/terraform/commons/local-references.go 71.87% <0.00%> (-8.13%) ⬇️
pkg/writer/human_readable.go 78.68% <0.00%> (-8.11%) ⬇️
pkg/config/global.go 79.45% <0.00%> (-7.09%) ⬇️
...providers/terraform/commons/variable-references.go 78.46% <0.00%> (-3.51%) ⬇️
...c-providers/terraform/commons/module-references.go 40.00% <0.00%> (-2.11%) ⬇️
pkg/results/types.go 100.00% <0.00%> (ø)
pkg/http-server/handler.go 100.00% <0.00%> (ø)
pkg/http-server/remote-repo.go 69.69% <0.00%> (ø)
pkg/termcolor/colorpatterns.go 33.33% <0.00%> (ø)
pkg/policy/opa/engine.go 65.57% <0.00%> (+0.01%) ⬆️
... and 10 more

@devang-gaur devang-gaur marked this pull request as draft May 10, 2021 23:43
@devang-gaur devang-gaur marked this pull request as ready for review May 11, 2021 14:28
@devang-gaur devang-gaur added this to Review in progress in Main Board May 11, 2021
kustomize/base/deployment.yaml Outdated Show resolved Hide resolved
kustomize/base/deployment.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@kanchwala-yusuf kanchwala-yusuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to move the kustomize directory from the root of the repo into deploy directory.
deploy has all the different ways of deploying terrascan server i.e docker-compose, helm charts.

kustomize/README.md Outdated Show resolved Hide resolved
kustomize/README.md Outdated Show resolved Hide resolved
kustomize/README.md Outdated Show resolved Hide resolved
kustomize/README.md Outdated Show resolved Hide resolved
kustomize/README.md Outdated Show resolved Hide resolved
kustomize/webhook/validating-webhook.yaml Outdated Show resolved Hide resolved
kustomize/README.md Outdated Show resolved Hide resolved
kustomize/README.md Outdated Show resolved Hide resolved
kustomize/README.md Outdated Show resolved Hide resolved
@devang-gaur
Copy link
Contributor Author

changes made @kanchwala-yusuf @Rchanger

@sonarcloud
Copy link

sonarcloud bot commented May 17, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@Rchanger Rchanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kanchwala-yusuf kanchwala-yusuf merged commit 07c1e4f into tenable:master May 18, 2021
Main Board automation moved this from Review in progress to Done May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants