Automate generation of TLS Certs using Helm #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul M Chheda <rahul.chheda@accurics.com>
Codecov Report
@@ Coverage Diff @@
## master #779 +/- ##
==========================================
+ Coverage 74.85% 78.22% +3.36%
==========================================
Files 111 162 +51
Lines 3345 4354 +1009
==========================================
+ Hits 2504 3406 +902
- Misses 656 734 +78
- Partials 185 214 +29
|
Signed-off-by: Rahul M Chheda <rahul.chheda@accurics.com>
Signed-off-by: Rahul M Chheda <rahul.chheda@accurics.com>
rahulchheda
changed the title
Signed-off-by: Rahul M Chheda <rahul.chheda@accurics.com>
|
@rahulchheda can you update the README there as well? |
devang-gaur
suggested changes
May 15, 2021
| {{ .Files.Get "data/server.key" | b64enc }} | ||
| cert: |- | ||
| {{ .Files.Get "data/server.crt" | b64enc }} | ||
| {{- if and (eq "" .Values.secrets.tlsCertFilePath) (eq "" .Values.secrets.tlsKeyFilePath) }} |
There was a problem hiding this comment.
either we should use or operator here or we should have additional else if cases that handle the cases where key is blank but cert is defined and vice versa.
There was a problem hiding this comment.
and would do the trick in this case, if any of the 2 keys are missing, it will error out somewhat like this: unknown object type "nil" in Secret.data.tls.crt
Signed-off-by: Rahul M Chheda <rahul.chheda@accurics.com>
…eature/auto-gen-secret Signed-off-by: Rahul M Chheda <rahul.chheda@accurics.com>
…eature/auto-gen-secret Signed-off-by: Rahul M Chheda <rahul.chheda@accurics.com>
Signed-off-by: Rahul M Chheda <rahul.chheda@accurics.com>
Signed-off-by: Rahul M Chheda <rahul.chheda@accurics.com>
Signed-off-by: Rahul M Chheda <rahul.chheda@accurics.com>
|
Kudos, SonarCloud Quality Gate passed!
|
devang-gaur
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I tried to create self-signed certificate for Terrascan Admission Controller using Helm. This seems to be a very simple implementation for this.
Signed-off-by: Rahul M Chheda rahul.chheda@accurics.com