Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we safely drop the Symbols support? #126

Closed
timche opened this issue Sep 1, 2016 · 5 comments
Closed

Can we safely drop the Symbols support? #126

timche opened this issue Sep 1, 2016 · 5 comments

Comments

@timche
Copy link
Member

timche commented Sep 1, 2016

With v1.0.0 we would also like to drop the Symbols support as they are not recommended and "generally a bad idea".

Before we are dropping it completely, is anyone using them extensively?

@yangmillstheory
Copy link
Contributor

FYI this is the original thread where we decided to adopt Symbol support.

@theghostbel
Copy link

You can put somewhere a "patch" so anyone can adopt "Symbal" supoprt if they need it. I personally don't know any project who uses Symbols.

@JaKXz
Copy link
Contributor

JaKXz commented Oct 28, 2016

I'm curious to see if there are any use cases for Symbols before just dropping them. From the Redux docs:

Note that it is okay to use Symbols, Promises, or other non-serializable values in an action if the action is intended for use by middleware. Actions only need to be serializable by the time they actually reach the store and are passed to the reducers.

but it might make more sense for FSA to "standardize" on strings only for the advantages mentioned.

@timche
Copy link
Member Author

timche commented Nov 1, 2016

If we are unsure about it, I think it's okay to keep it. It doesn't do anything harmful.

@JaKXz
Copy link
Contributor

JaKXz commented Nov 2, 2016

@timche I agree - I think it makes a better candidate for the next major version to be dropped. We can mark it as deprecated for now and see if there's pushback.

It also shouldn't block this release any more than it has :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants