Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in 2.1.0 #263

Closed
catamphetamine opened this issue Jul 22, 2016 · 5 comments · Fixed by #264
Closed

Breaking change in 2.1.0 #263

catamphetamine opened this issue Jul 22, 2016 · 5 comments · Fixed by #264

Comments

@catamphetamine
Copy link
Contributor

I've just tried the new 2.1.0 and it introduced a breaking change - there's no more redux-router/server
https://npmcdn.com/redux-router@2.0.0/server.js

I used to use match and reduxReactRouter from that module.
Is there a possibility to get these two functions in 2.1.0?

@Scarysize
Copy link
Contributor

Scarysize commented Jul 22, 2016

This just has to be an issue with the updated build tasks. I will look into it.

EDIT: see #258

Maybe you can spot the error real quick.

@catamphetamine
Copy link
Contributor Author

catamphetamine commented Jul 22, 2016

Well, the scripts are as they were but it's the added files property.
https://docs.npmjs.com/files/package.json#files
It simply misses server.js, so it gets npmignored.
Try to add it there and republish as a bigfix.

@catamphetamine
Copy link
Contributor Author

catamphetamine commented Jul 22, 2016

I don't know why was that files field introduced in the first place.
Usually everyone goes with .npmignore.

@Scarysize
Copy link
Contributor

To work with npmcdn.com

@Scarysize
Copy link
Contributor

Published v2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants