Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smarter pooling layers #10

Open
rkurchin opened this issue Aug 27, 2020 · 0 comments
Open

smarter pooling layers #10

rkurchin opened this issue Aug 27, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@rkurchin
Copy link
Member

rkurchin commented Aug 27, 2020

A few ideas here:

  • Specifically for the adsorption problem, we could add a feature for whether that atom is part of the adsorbate or catalyst, as well as particular parts of catalyst (e.g. SAC or scaffold, or which layer of MPEA) and preferentially pool those atoms together first (this would obviously also require changes in the ChemistryFeaturization repo)
  • a more general approach like EigenPooling would also be cool to implement: PyTorch version here (NB: you still need a way to designate subgraphs beforehand with this approach, so perhaps could be combined with the idea above, and/or just use the spectral approach that they adopt in the paper)
  • there's also this bi-level graph idea (they combined with GAT's though)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant