Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate ical entries from different sources #215

Closed
guerda opened this issue Apr 1, 2022 · 3 comments
Closed

Duplicate ical entries from different sources #215

guerda opened this issue Apr 1, 2022 · 3 comments
Assignees
@aceisace
Labels
improvement This is an improvement no-issue-activity

Comments

@guerda
Copy link

guerda commented Apr 1, 2022

Describe the bug
If two ical calendar sources contain the same event (e.g. one as invitee, one as organizer), the ical agenda shows them duplicate, even if the UID is the same.

To Reproduce

  1. Create two ICS files with the same event (same UID)
  2. Setup agenda module with both ICS files.
  3. Start inkycal

Expected behavior
Only one instance of this event is shown
@aceisace aceisace self-assigned this Apr 1, 2022
@aceisace aceisace added the improvement This is an improvement label Apr 1, 2022
@aceisace
Copy link
Collaborator

aceisace commented Apr 1, 2022

Thanks for the details. Just writing some info for when I implement this officially

  • Parse all events
  • Convert List->Set->List to remove duplicate entries
  • Write test for this case

@github-actions
Copy link

github-actions bot commented Jan 19, 2023 •
edited by aceisace

Marking this issue as stale due to inactivity

@github-actions
Copy link

Marking this issue as stale due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aceisace aceisace

Labels
improvement This is an improvement no-issue-activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guerda @aceisace