Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Todoist Module #226

Closed
Semmidemmi263 opened this issue Dec 29, 2022 · 2 comments
Closed

Bug in Todoist Module #226

Semmidemmi263 opened this issue Dec 29, 2022 · 2 comments
Assignees
Labels
waiting for feedback Waiting for feedback

Comments

@Semmidemmi263
Copy link

Describe the bug
For several projects in the project_filter, the inkycal_todoist module only imports the first project.

To Reproduce
Try to import more than one project from todoist.

Expected behavior
All tasks from all projects in the project_filter list should be imported and printed. Here, a small bug has been found: In the for-loop which is used to generate the image, the else case with break ("more todos than available lines") is lined up with "if todos:". It should line up with "if cursor < len(line_positions):". This change in the code has solved the issue for me.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: raspberry OS

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@aceisace
Copy link
Collaborator

aceisace commented Jan 8, 2023

Hi there @Semmidemmi263 . May I kindly ask you to check this branch of Inkycal:
https://github.com/aceisace/Inkycal/tree/feature/venv

If the issue persists there as well, please let me know. That branch is basically the new release containing several bugfixes. At the moment, I have tested it myself and it seems to work. To ensure that it really is working as expected, any help testing that branch is much appreciated so I can merge that branch into main and create a new release soon

@aceisace aceisace self-assigned this Jan 8, 2023
@aceisace aceisace added the waiting for feedback Waiting for feedback label Jan 8, 2023
@Semmidemmi263
Copy link
Author

Hi aceisace,
The same goes for this issue: your fix helps to resolve it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for feedback Waiting for feedback
Projects
None yet
Development

No branches or pull requests

2 participants