This repository has been archived by the owner on Aug 20, 2021. It is now read-only.
Display attached images in HTML emails #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables embedding of images inside html template <img src="cid:logo.png" alt="Logo"> Similar header is added for every attachment and can be used as in above example Content-ID:<logo.png>
|
Nice feature! |
|
You are on time to fix it. Just send more commits to your branch. $basename = basename($attachment);
$part->id = $basename;
$part->filename = $basename; |
|
Just checked with the last modification and works great! I didn't knew how this worked. |
Now the embedding of images should work correctly.
|
As you suggested I've added the omitted basename function from earlier. |
acelaya
added a commit
that referenced
this pull request
Jun 14, 2014
Display attached images in HTML emails
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables embedding of images inside html template
<img src="cid:logo.png" alt="Logo">
Similar header is added for every attachment and can be used as in above example
Content-ID:<logo.png>