Require SQL comment hint

[ossinkine]

Doctrine can't detect field type with no comment hint when get schema from DB.
For example, Doctrine creates migration with changing field type even if field type is already correct.

[acelaya]

I think I don't follow you. Could you provide an example?

[ossinkine]

See https://github.com/ossinkine/symfony-standard/tree/reproducer-acelaya-doctrine-enum-type-14
This is Symfony Standard 3.3 with installed Doctrine migrations bundle and this library according to readme.
Steps to reproduce:

1. Run composer install
2. Run docker-compose up -d
3. Run docker-compose exec php bin/console doctrine:migrations:diff. The following SQL is generated:

CREATE SEQUENCE users_id_seq INCREMENT BY 1 MINVALUE 1 START 1;
CREATE TABLE users (id INT NOT NULL, name VARCHAR(255) NOT NULL, gender VARCHAR(255) NOT NULL, PRIMARY KEY(id));

4. Run docker-compose exec php bin/console doctrine:migrations:migrate
5. Run docker-compose exec php bin/console doctrine:migrations:diff again. The following SQL is generated:

ALTER TABLE users ALTER gender TYPE VARCHAR(255);
ALTER TABLE users ALTER gender DROP DEFAULT;

[ossinkine]

This reproducer for Postgres driver, MySQL driver has the same behavior

[acelaya]

Wow! Thanks for the detailed information.

I have been researching, and this update makes sense. I didn't know about this feature.

In fact I'm going to consider it a hotfix and release v2.0.3

Thank you very much for your help :-)