-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
优化/修复项建议 #20
Comments
|
|
c.msgChan <- msg //chan满时导致阻塞,比如3中的场景,应用层持续给这个连接SendMsg,满了,然后阻塞了,如果应用层是广播的逻辑后者任务池中发的这个包,其他模块就都被阻塞了,直到此连接其他情况退出时才恢复 |
只看了几分钟代码,暂时感觉以上几个地方存在问题,如果有讲的不准确的地方咱们再讨论,作者大佬看下是否需要优化、修复 |
非常感谢您的建议,我们会斟酌您的建议 修正之后合并到代码之中,如果您也想直接修复的话,也可以直接提交 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
此处go了一个新协程是可以省略的,dealConn.Start() 中又go了读写两个协程就可以了,如果怕CallOnConnStart有慢操作影响accept速度,可以把CallOnConnStart移到读协程中去执行
The text was updated successfully, but these errors were encountered: