Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better explanation #131

Open
richbar88 opened this issue Aug 17, 2018 · 0 comments
Open

better explanation #131

richbar88 opened this issue Aug 17, 2018 · 0 comments
Labels
code review This issue originated from a code review

Comments

@richbar88
Copy link
Collaborator

https://github.com/mmuellerstoffels/GBSTools/blob/7a20352a8b83e60f675273a79e43e3bfa5dd3385/GBSTool/GBSModel/generateRuns.py#L154-L172
Better documentation is needed here.
Suggestion: Since “TryTag” originates from “compValue”. It could be explained what has to be done if
“TryTag” (“compValue”) is in “compTag” (line 105) or why can “TryTag” (“compValue”) be in
“compTag”?
@richbar88 richbar88 added the code review This issue originated from a code review label Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code review This issue originated from a code review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richbar88