Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select all text and press -/. #15

Open
acgc99 opened this issue Aug 4, 2023 · 0 comments
Open

Select all text and press -/. #15

acgc99 opened this issue Aug 4, 2023 · 0 comments
Labels
bug Something isn't working limitation Feature that cannot be implemented due to incompatibilities or Godot wontfix This will not be worked on

Comments

@acgc99
Copy link
Owner

acgc99 commented Aug 4, 2023

Select all text and press -/. used to crash app/game. This didn't happen with the rest of keys. The solution created a limitation.

This is a limitation, it will delete all text because _on_text_changed is called twice.

if new_text == "-" or new_text == ".":
	text = ""
	old_text = ""
	old_text_length = 0
#	old_text = new_text
#	old_text_length = 1

The commented lines (and removing the two above) would solve the problem since in the first call -/. is new_text and in the second it would be old_text. But this would break that when deleting 0 from -0/0. also delete -/. and similars.

@acgc99 acgc99 added bug Something isn't working wontfix This will not be worked on labels Aug 4, 2023
@acgc99 acgc99 added this to the vX milestone Aug 4, 2023
@acgc99 acgc99 changed the title Limitation: select all text and press -/. Select all text and press -/. Aug 5, 2023
@acgc99 acgc99 added the limitation Feature that cannot be implemented due to incompatibilities or Godot label Aug 5, 2023
@acgc99 acgc99 removed this from the vX milestone Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working limitation Feature that cannot be implemented due to incompatibilities or Godot wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant