Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeouts to requests #112

Open
goncalor opened this issue Nov 4, 2019 · 0 comments
Open

Add timeouts to requests #112

goncalor opened this issue Nov 4, 2019 · 0 comments

Comments

@goncalor
Copy link
Contributor

goncalor commented Nov 4, 2019

According to the requests documentation "requests to external servers should have a timeout attached, in case the server is not responding in a timely manner."

I opened PR #111 to add timeouts to one method. Although I'm in a position to test that method, the same is not true of the remaining methods. I decided to open this issue in order to prevent any breakage further changes might cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant