Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record score #8

Open
mauvqz opened this issue Dec 10, 2021 · 1 comment · Fixed by #11
Open

Record score #8

mauvqz opened this issue Dec 10, 2021 · 1 comment · Fixed by #11

Comments

@mauvqz
Copy link
Collaborator

mauvqz commented Dec 10, 2021

/record(or something else) - Allows each player to record their percentage/score of the day

@mauvqz mauvqz linked a pull request Dec 11, 2021 that will close this issue
@mauvqz mauvqz self-assigned this Dec 12, 2021
@mauvqz mauvqz linked a pull request Dec 12, 2021 that will close this issue
@mauvqz mauvqz removed a link to a pull request Dec 26, 2021
@mauvqz
Copy link
Collaborator Author

mauvqz commented Dec 26, 2021

Achim:

Right now a score is tied to a day (and the notion of a day depends on the timezone of the server) which might not be optimal. Maybe we can have something like record sessions, where a session ends either when all players have recorded their score or when the /end_session command is called.

I agree with this comment, we should be able to start/end a session of recording. The only issue with this is that if anyone is able to start/end a session, then we open ourselves to user errors where a session is ended before it should be. If this is not a problem, then we can proceed as mentioned in the quote. Otherwise we should assign some sort of "session master" where whoever starts the session, is the only one allowed to close it.

@mauvqz mauvqz removed their assignment Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant