Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky v9 macOS and Windows tests #25

Open
achrinza opened this issue Mar 25, 2022 · 0 comments
Open

Flaky v9 macOS and Windows tests #25

achrinza opened this issue Mar 25, 2022 · 0 comments

Comments

@achrinza
Copy link
Owner

achrinza commented Mar 25, 2022

The macOS and Windows tests are flaky. Specifically, this test:

1) TCP Socket verification of client Verify retry attempts by TCP client to connect to the server as per the value set in "maxRetries" parameter.
  Message:
    Expected 2 to be 3.
  Stack:
    Error: Expected 2 to be 3.
        at Timeout.testDelay [as _onTimeout] (/Users/runner/work/node-ipc/node-ipc/spec/support/jasmineTest/TCP/tcpSocketClient.spec.js:48:44)
        at ontimeout (timers.js:436:11)
        at tryOnTimeout (timers.js:300:5)
npm ERR! Test failed.  See above for more details.
        at listOnTimeout (timers.js:263:5)

11 specs, 1 failure

Example run: https://github.com/achrinza/node-ipc/runs/5631442749?check_suite_focus=true

This issue is track for a potential solution to improving the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant