Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark loading-benchmark fails to build with GHC 7.10 #139

Closed
andreasabel opened this issue Feb 13, 2022 · 3 comments · Fixed by #140
Closed

Benchmark loading-benchmark fails to build with GHC 7.10 #139

andreasabel opened this issue Feb 13, 2022 · 3 comments · Fixed by #140

Comments

@andreasabel
Copy link
Collaborator

andreasabel commented Feb 13, 2022

https://github.com/andreasabel/acid-state/runs/5173813620?check_suite_focus=true#step:19:98

Building benchmark 'loading-benchmark' for acid-state-0.16.0.1..
...
[4 of 4] Compiling Main             ( benchmarks/loading/Benchmark.hs, /__w/acid-state/acid-state/dist-newstyle/build/x86_64-linux/ghc-7.10.3/acid-state-0.16.0.1/b/loading-benchmark/build/loading-benchmark/loading-benchmark-tmp/Main.o )

benchmarks/loading/Benchmark.hs:89:34: Not in scope: ‘perRunEnv’

This function was added in criterion-1.2, see https://hackage.haskell.org/package/criterion-1.2.0.0/changelog.

@ddssff ddssff closed this as completed Feb 18, 2022
@ddssff
Copy link
Collaborator

ddssff commented Feb 18, 2022

Wait so this is resolved?

@andreasabel
Copy link
Collaborator Author

Wait so this is resolved?

Depends. For the latest versions of acid-state, yes (see list above). I did not fix all of the acid-state build plans, because matrix.hackage is still broken and maybe no one cares about older versions of acid-state.

So, practically, yes.
Theoretically, no, all versions out there that use perRunEnv without criterion >= 1.2are still broken.
But fine to close the issue and wait if someone comes complaining...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants