Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHC versions covered by AppVeyor CI #143

Closed
adamgundry opened this issue Apr 6, 2022 · 3 comments · Fixed by #160
Closed

GHC versions covered by AppVeyor CI #143

adamgundry opened this issue Apr 6, 2022 · 3 comments · Fixed by #160
Labels
re: continuous integration (CI) Concerning continuous integration

Comments

@adamgundry
Copy link
Contributor

Looking at https://ci.appveyor.com/project/stepcut/acid-state it appears AppVeyor is running CI with GHC 8.2 and 8.4. In contrast the Linux CI has everything from 7.10 to 9.2. Perhaps some more recent versions should be included on AppVeyor?

@andreasabel
Copy link
Collaborator

Perhaps some more recent versions should be included on AppVeyor?

I suppose so, but I have never used AppVeyor.
I think it could be tried to extend the AppVeyor matrix. If this does not work well, we could also try a GHA workflow for windows (and macOS). [But maybe we need not actively work towards a GHA monopoly.]

acid-state/appveyor.yml

Lines 6 to 14 in 9d9efd9

matrix:
# - GHCVER: "8.6.3"
# CHOCOPTS:
# TEST: --enable-tests
# BENCH: --enable-benchmarks
- GHCVER: "8.4.4"
CHOCOPTS:
TEST: --enable-tests
BENCH: --enable-benchmarks

@stepcut
Copy link
Member

stepcut commented Apr 26, 2022

I think the primary reason for using appveyor at all is to ensure that the build works on Windows. That is somewhat important since we do have windows specific code in src-win32.

I don't think we need to test against every version of GHC on Windows like we do on Linux.

It is definitely annoying that the 8.2.2 is always failing on Appveyor at the moment.

I'd be fine with just testing GHC 9.2 on Windows. But I have no idea how to do that.

I am not opposed to also testing on OS X, but it seems less important since it uses the same code as Linux. Though, it is also true that the testsuite currently fails on OS X for boring reasons. But that does indicate that automated testing could be useful to discover OS X specific issues.

I have no opinion on appveyor vs github workflows vs other.

@andreasabel
Copy link
Collaborator

Historically, I think AppVeyor was the tool of choice for a Windows CI due to limited availability of alternatives.

A GHA CI could be similar to this: https://github.com/haskell/text-icu/blob/52822ec7684e39d3ee5afcd0d807f902971c0761/.github/workflows/cabal-mac-win.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
re: continuous integration (CI) Concerning continuous integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants