New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHD 630: avoidFirmwareLoading
fix doesn't work occasionally after waking up
#748
Comments
Thank you for your information, but excuse me, would you mind elaborating about the related details for the problem? |
Apple GuC is required for proper power management, which does not work on non-Apple computers. |
but It is strange that it only randomly happens about once for five times waking up. |
You may try to check syslog messages from IGFX kexts, it usually includes a rather detailed trace. |
Thanks for your advice.
Though I don't know the reason for the log repeating, to my knowledge, I can't figure out anything strange. |
Update:
Everything is ok now, though no idea why it is okay to load the firmware on my UHD 630. Logboot log
sleep log
|
Sorry, do you mean that Apple GuC firmware loads for you? |
I not sure it is loaded or not. I remove the following code in - if (forceOpenGL || moderniseAccelerator || avoidFirmwareLoading) {
- auto startSym = "__ZN16IntelAccelerator5startEP9IOService";
- if (cpuGeneration == CPUInfo::CpuGeneration::SandyBridge)
- startSym = "__ZN16IntelAccelerator5startEP9IOService";
-
- KernelPatcher::RouteRequest request(startSym, wrapAcceleratorStart, orgAcceleratorStart);
- patcher.routeMultiple(index, &request, 1, address, size);
-
- if (loadGuCFirmware && getKernelVersion() <= KernelVersion::Mojave)
- loadIGScheduler4Patches(patcher, index, address, size);
- } can you determine from the log attached? |
Well, it does look like it is using Apple GuC. What I cannot understand is how can it work on a generic computer. What is the manufacturer of your laptop? I can implement the code to conditionally disable Apple-only firmware checks, but that is quite weird. |
The ODM model is Tongfang GK5CP6X. https://www.reddit.com/r/EVOOGaming/comments/e94z7z/info_tongfang_gk5cp6x/ It seems quite normal, but the CPU i7-9750H is also equipped on the MacBook Pro 15,1 (2019), which is the model choice in my SMBIOS config. Maybe we can test on other laptops with a similar condition. |
Yes, this makes sense to me. Sure, I will add a way to configure GuC firmware switch-off. It will also make sense to test DRM playback and perform provisioning. |
Regarding GuC, I pushed changes adding support to forcing Apple GuC firmware loading on any machine. This is what you want to use. Regarding DRM, bitmovin.com test site is not useful, as it does not use any hardware. Same for Chromium/widevine. iTunes movies, encrypted iTunes trailers, and Apple TV are relevant. You are best to test Apple TV (there are free shows, usually first episodes), as iTunes trailers do not require HDCP, and can be patched fully with software. So, what I want you to do is to test:
|
We should also advise users to try enabling those flags to get better IGPU performance |
Quite possible if it is stable… |
Sorry, is it for just Laptops? |
Not necessarily. It seems to work with (very few) laptops and may also work with (very few) desktops. Do not expect too much. |
@vit9696 thanks for this, It seems that macmini 6,1 has the same IGPU device IDs that my desktop have. This is amazing, thanks a lot !
|
@Sniki |
So you what you are saying that i only need igfxpavp=1 for DRM-Content to work ? |
Trailer from ShikiFAQ shows without boot-args. It was solved long ago. |
GuC firmware load successfully on my device too with WEG 1.3.8. My Laptop is XPS 9570 Intel i7 8750h. Also the power management is a lot better.Idle pkg power went down from 2.8Watts to .9 Watts.I dont know if this is all cause of Apple Firmware.But it surely did have an impact. |
I added igfxfw=2 igfxpavp=1 boot flags on my Intel UHD620 , but when playing video ,touchpad freezes for a sec or so and then starts again. |
Remove these boot-arguments. |
I have Intel i5-8250u, which is 14nm. |
It not chipset, it CPU. |
Related specs of my laptop:
The
avoidFirmwareLoading
fix in WhateverGreen resolves the sleep issue on my laptop. Without WhateverGreen, the laptop won't sleep properly, stuck after the screen turns off.However, occasionally, when the laptop wakes up from sleep, the lowest frequency of the UHD 630 will be locked to 350MHz and the laptop will not be able to sleep again, just like what happens when WhateverGreen or the
avoidFirmwareLoading
is removed.I tried removing all the other patches in WhateverGreen but it was not helpful. Hence it is not caused by the other parts of WhateverGreen.
Does anyone have any idea what causes this? Does the firmware loading happen when waking up?
Feel free to ask me for more related information. Thanks in advance.
The text was updated successfully, but these errors were encountered: