Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retain is bit 0 of the flags, not bit 3 #24

Merged
merged 2 commits into from
May 24, 2017
Merged

retain is bit 0 of the flags, not bit 3 #24

merged 2 commits into from
May 24, 2017

Conversation

paulw11
Copy link
Contributor

@paulw11 paulw11 commented May 22, 2017

fixedHeaderFlags(for:) incorrectly set bit 3 rather than bit 0 for retained messages with the result that retained messages could not be published

bhargavg
bhargavg requested changes May 23, 2017
View reviewed changes
Copy link
Collaborator

@bhargavg bhargavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @paulw11

Do you mind adding a small unit test for checking the header format?

@bhargavg
Copy link
Collaborator

LGTM, Thanks for the PR.

@bhargavg bhargavg merged commit e1e11b3 into aciidgh:master May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhargavg bhargavg bhargavg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulw11 @bhargavg