Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IncomingPayment.received.amount is incorrect (when NewChannel) #187

Closed
robbiehanson opened this issue Feb 2, 2021 · 1 comment · Fixed by #189
Closed

IncomingPayment.received.amount is incorrect (when NewChannel) #187

robbiehanson opened this issue Feb 2, 2021 · 1 comment · Fixed by #189

Comments

@robbiehanson
Copy link
Contributor

robbiehanson commented Feb 2, 2021

When receiving an IncomingPayment, such that a new channel is created, the IncomingPayment.received.amount doesn't match the user's balance:

Screen Shot 2021-02-02 at 10 43 10

Screen Shot 2021-02-02 at 10 43 14

Screen Shot 2021-02-02 at 10 43 24

Steps to reproduce:

  • Start with a clean wallet (no existing channels)
  • Receive an incoming payment of 15,000 sat
  • Notice that wallet balance is reported as 14,000 sat (as is channel balance)
  • Notice that IncomingPayment.received.amount = 14,985 sat, with fees of only 15 sat
@t-bast
Copy link
Member

t-bast commented Feb 2, 2021

That is linked to the recent pay-to-open changes made by @pm47 and @dpad85
The pay-to-open fee is deducted on the recipient end, so that end result is expected, but we should show the right fee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants