Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing default config buffer_opts requires messages.utils #4

Closed
dsully opened this issue Sep 20, 2022 · 3 comments · Fixed by #11
Closed

Changing default config buffer_opts requires messages.utils #4

dsully opened this issue Sep 20, 2022 · 3 comments · Fixed by #11

Comments

@dsully
Copy link
Contributor

dsully commented Sep 20, 2022

Hi - thanks for the plugin! I'm trying to change the window border style, but in the buffer_opts function, the return map calls clip_val, which means I need to import messages.utils in order to use it.

Perhaps a slight restructuring of the config such that window styles can be separated out?

@AckslD
Copy link
Owner

AckslD commented Sep 20, 2022

I'm not sure I understand why that's an issue? Currently the buffer_opts uses the tiny function in utils to determine the floating window size. Are you worried about loading time?

@dsully
Copy link
Contributor Author

dsully commented Sep 20, 2022

No, not worried about loading time. Just that in order to change a single value (border from "rounded" to "single"), I need to copy the entire function into my config.

@AckslD
Copy link
Owner

AckslD commented Sep 20, 2022

I see, I'd be fine with moving the static values to separate settings which can be used by the callback. But I think it's still nice to have the callback for the user to make these decisions dynamically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants