-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for wayland is not implemented #36
Comments
This seems very fixable. Ash has bindings for this. I don’t have a good way of testing but I could probably get something to compile, and hopefully it will be close enough that someone could help if it doesn’t work. |
I pushed a commit that should implement support for Wayland and xcb. If you have a chance to give it a try please let me know how it goes! |
Cool, just tried it. Doesn't panic anymore but does seem to freeze. I'll see if I can get more info. |
Out of curiosity, does a window pop? Does anything draw? What does freeze mean? |
@Kethku nothing draws, no window. It doesn't freeze so much as just doesn't do anything, the event loop stops going but it still responds to sigint |
Unfortunately I don't have a machine using Wayland or time to build one right now. I'm happy to look at the log if you post it in case something obvious sticks out, but this one might need outside assistance. |
Looks like the call to winit::window::Window::request_redraw is where things hang (neovide::editor::mod.rs line 90), will try to dig further into that |
With wayland debug output:
|
Running this under kwin-wayland does show a window with a colored background, but hits the same point and freezes |
I'm not sure if it's related, but it's probably worth watching this bug: rust-windowing/winit#1388 |
New bug, not super sure what changed in the meantime. Instead of just freezing it panics now. Output with WAYLAND_DEBUG enabled is:
|
This may actually be resolved, bumping the version of skulpin that neovide tracks gets it working for me. |
I will bump the version sometime today Sent with GitHawk |
Bumped. |
This should probably be closed now. |
@Kethku sadly, the same error is still here.
|
@szbergeron did you just bump it to 0.5.1? Or did you swap to tracking github. The errors you guys got seem pretty similar. Did you install any other dependencies to get it working? |
We might also consider moving this to the neovide repo to stop bothering aclysma |
@Kethku bumped to track master |
Going to reopen this to remind myself to push a 0.5.1 that includes the wayland changes. Glad it’s working! |
0.5.2 is published and contains these changes |
Originally reported as neovide/neovide#33,
Panic comes from https://github.com/aclysma/skulpin/blob/master/src/renderer/window_support.rs#L45
The text was updated successfully, but these errors were encountered: