Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common name to CSR payload #16

Closed
alexmckinnon opened this issue Aug 14, 2018 · 1 comment
Closed

Add common name to CSR payload #16

alexmckinnon opened this issue Aug 14, 2018 · 1 comment

Comments

@alexmckinnon
Copy link

The CSR payload currently doesn't contain the common name, resulting in the subject of the CSR not having a CN value defined.

Example:
Subject: C=CA, ST=British Columbia, L=Nanaimo, O=NA/emailAddress=alex@example.com

Adding the common name to getCSRPayload in CertificateRequestSigner will result in:

Subject: C=CA, ST=British Columbia, L=Nanaimo, O=NA, CN=example.com/emailAddress=alex@example.com

@alexmckinnon
Copy link
Author

Moved issue to original repo: acmephp/acmephp#129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant