Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--preferred-chain is broken (on renewal) #3116

Closed
GermanCoding opened this issue Aug 20, 2020 · 1 comment
Closed

--preferred-chain is broken (on renewal) #3116

GermanCoding opened this issue Aug 20, 2020 · 1 comment

Comments

@GermanCoding
Copy link

I'm running acme.sh on current master (c5eea2e)

Steps to reproduce

acme.sh --issue -d <domain> --preferred-chain  "ISRG Root X1"

This generates a new config (domain.conf in .acme.sh subfolder) for the domain, which saves the preferred-chain setting

Le_Preferred_Chain='__ACME_BASE64__START_SVNSRyBSb290IFgx__ACME_BASE64__END_'

This is correct (the base64 encodes "ISRG Root X1"). But, once you renew the certificate

acme.sh --renew --force -d <domain>

the config entry gets changed to:

Le_Preferred_Chain='__ACME_BASE64__START_X19BQ01FX0JBU0U2NF9fU1RBUlRfU1ZOU1J5QlNiMjkwSUZneF9fQUNNRV9CQVNFNjRfX0VORF8=__ACME_BASE64__END_'

which is the base64 encoding of __ACME_BASE64__START_SVNSRyBSb290IFgx__ACME_BASE64__END_ and not ISRG Root X1.

So the base64 gets encoded again in base64! So of course this breaks the chain selection on renewal, because the base64 changes to absolute nonsense.

@GermanCoding
Copy link
Author

GermanCoding commented Aug 20, 2020

I can still reproduce this on current dev/master brach, even with the fix. Sadly my shell programming skills are insufficient to figure out where the problem is exactly.

EDIT: It seems the upgrading didn't work correctly, my staging test works now (after manually pulling from the dev branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant