dns_ispconfig.sh broken

[remkohat]

Latest alterations in dns_ispconfig.sh broke the script!
As a result acme.sh is saying "You haven't specified the ISPConfig Login data" though it is specified in account.conf.
This happens when running the cron to autorenew and also when trying to get a new certificate from the command line.

After I replaced the script with the previous version all is working fine again.

What I also don't understand is why acme.sh is saying it's on version 3.0.2 when here on Github it says that latest version is 3.0.1

[Neilpang]

3.0.2 is not released yet. 3.0.1 is the latest released version.

[remkohat]

Released or not, the autoupdate function in acme.sh apparently updates it to 3.0.2
And with a broken dns_ispconfig.sh

[andzio]

/root/.acme.sh/acme.sh -v
https://github.com/acmesh-official/acme.sh
v3.0.2

/root/.acme.sh/acme.sh --server https://acme-v02.api.letsencrypt.org/directory --issue --dns dns_ispconfig --keypath /etc/pve/local/pveproxy-ssl.key --fullchainpath /etc/pve/local/pveproxy-ssl.pem --reloadcmd "systemctl restart pveproxy" -d domain.com

You haven't specified the ISPConfig Login data, URL and whether you want check the ISPC SSL cert. Please try again.

[remkohat]

@Neilpang In my case different paths but exactly the same result as @andzio

@andzio As a workaround for now overwrite dns_ispconfig.sh with the previous version of the file (Jan 16 2021)

[andzio]

Yes, the old version works ok, so I overwritten it, but it's just a denture.

[iNetSpec]

@Neilpang The culprit is in this commit from January 6, 2022 which should be reverted. The "-n" comparison operator in bash means a string has a "non-zero" length. The author of the change misunderstood the usage and context.
d32cedd

[Neilpang]

fixed, can you guys please try with the latest dev branch?

acme.sh --upgrade -b dev

[iNetSpec]

@Neilpang I essentially already tested by editing the file on two of my machines that were giving the same error as above before reporting the commit as the problem; so "works for me".

[RBCOMGmbH]

fixed, can you guys please try with the latest dev branch?

acme.sh --upgrade -b dev

Without manually changing anything I can also confirm that your changes in the dev branch worked.
Thank you for fixing it!