-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frozen merge naming #5
Comments
I have never heard about this feature and it was not implemented in acmacs. Frozen merge (requested by other people) is different: two maps are oriented to each other using procrustes and resulting coordinates (in the merge) are copied from the oriented sources, coordinates for common points are means of coordinates in the oriented sources. I will add implementation of what you described into my todo list. You may suggest the name, it cannot be "frozen merge" because that name is busy with feature described above. I understand that people may be confused by naming. Some time ago we had discussion with Derek about names for overlay and frozen megres (implemented in acmacs) and current names are result of that discussion. I am not going to change the names. People have to get used to the "new" names. |
I spoke to Derek about it and he also thinks it's best to be consistent with the lispmds names (that was what he expected you'd done), as many people using acmacs.r will have started with lispmds. |
To break the infinite loop of renaming I decided to rename functions in the following way. I assign numbers to different merge types, i.e. functions will be called acmacs.merge.1, acmacs.merge.2, etc. And I will update documentation (?acmacs.merge) accordingly. Then you may create your own function called say merge_frozen which just calls whatever acmacs.merge.N function you think it corresponds to. Or you ask Sam to create that kind of function in Racmacs, if you wish. Other people who may have their own opinion on what frozen merge is will be able to create and name their own functions whatever they like. |
👍 |
implemented in v4.0 |
The name "frozen" has a different meaning in lispmds and acmacs.R , which confused me. In lispmds, "frozen" means that map1 is fixed and the points in map2 (really the data from table2) are optimised. This is a useful feature for merging in less reliable data so it would be helpful to have this functionality. It would also be good to change the name in acmacs.R to avoid other people with experience with lispmds making the same mistake as I did.
(I know you're on holiday so I'm not expecting a reply anytime soon!)
The text was updated successfully, but these errors were encountered: