This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Set ingress class name when we need it #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A common scenario we see is that even though ingress-nginx is installed, it isn't set as the default ingress class. In this case, when we create an ingress, it never gets picked up. So, to make ingress work in this scenario, if we detect that the cluster has exactly one ingressClass and it isn't set at the default, we are just going to assume the user wants to use it and set it when we create an ingress. Bonus: found a bug where if Docker Desktop has an ingress already installed, we still set acorn's ingress class name to "traefik". We should only set the ingressClassName field for Docker Desktop if we are installing traefik. Signed-off-by: Craig Jellick <craig@acorn.io>
|
addresses #727 |
ibuildthecloud
approved these changes
Oct 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common scenario we see is that even though ingress-nginx is installed,
it isn't set as the default ingress class. In this case, when we create an
ingress, it never gets picked up.
So, to make ingress work in this scenario, if we detect that the cluster
has exactly one ingressClass and it isn't set at the default, we are
just going to assume the user wants to use it and set it when we create
an ingress.
Bonus: found a bug where if Docker Desktop has an ingress already
installed, we still set acorn's ingress class name to "traefik". We
should only set the ingressClassName field for Docker Desktop if we are
installing traefik.
Signed-off-by: Craig Jellick craig@acorn.io