Types for LooseParser constructor are wrong

[connor4312]

The types say that LooseParser is just a Parser

acorn/acorn-loose/src/acorn-loose.d.ts

Line 3 in bde8b2d

export const LooseParser: typeof acorn.Parser

...which orders is arguments as options, input...

acorn/acorn/src/acorn.d.ts

Line 736 in bde8b2d

constructor(options: Options, input: string, startPos?: number)

...but LooseParser actually takes the arguments in reverse order:

acorn/acorn-loose/src/state.js

Line 7 in bde8b2d

constructor(input, options = {}) {

[marijnh]

The constructors aren't really part of the public interface. In what situation are you calling them?

[connor4312]

I was extending the parser class, adding an additional property that I want to read after calling parse(), so my usage was const p = new MyParser(...); const ast = p.parse(); doSomethingElseWith(p.prop). (This is a little sketchy, and I eventually went a different route for another reason.)

If the parser constructor is not meant to be public API, perhaps it should be marked as protected in the types to avoid external callers?