Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect peer dependency #6

Open
david-gettins opened this issue Mar 21, 2024 · 5 comments
Open

Incorrect peer dependency #6

david-gettins opened this issue Mar 21, 2024 · 5 comments

Comments

@david-gettins
Copy link

david-gettins commented Mar 21, 2024

The peer dependency web-streams-polyfill should be <4. In web-streams-polyfill@>=4 the import of web-streams-polyfill/ponyfill/es6 fails as the JS files have been renamed.

See the changelog for more info.

@david-gettins
Copy link
Author

Alternatively you could update it to work with v4 and set the peer dependency to >=4.

@david-gettins
Copy link
Author

On investigation, due to mocking in the tests, you would not see this issue...

jest.mock('web-streams-polyfill/ponyfill/es6', () => ({
    ReadableStream: () => 'ReadableStream',
}), { virtual: true });

@david-gettins
Copy link
Author

I've submitted a PR to help get this moving, #7.

@makeiteasierapps
Copy link

I've submitted a PR to help get this moving, #7.

I would love if they could get this updated??

Did you happen to find another solution?

@david-gettins
Copy link
Author

@makeiteasierapps

Installing web-stream-polyfill at v3 ensures you don't end up with v4. It would be great if the author merged the PR to prevent mistakenly using v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants