Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering services by labels #123

Closed
dvkch opened this issue Dec 12, 2022 · 4 comments
Closed

Allow filtering services by labels #123

dvkch opened this issue Dec 12, 2022 · 4 comments
Labels
enhancement New feature or request provider Issue related to a provider

Comments

@dvkch
Copy link

dvkch commented Dec 12, 2022

Hello!

Thanks for this amazing tool! I am currently using it in a Traefik/Swarm scenario, and was wondering about replacing selecting the services using names with a label or an env on the service itself.

That would allow to add new services to a swarm easily, and let Sablier know if it needs to handle it or not, without having to edit Sablier's config everytime.

Thanks for considering :)

@acouvreur
Copy link
Owner

acouvreur commented Dec 13, 2022

Very good suggestion, it would also allow to configure specific requirements which I wasn't able to do correctly, such a number of replicas.

Only kubernetes had this feature.

I will probably do this as a PoC when I have the time.

Feel free to open a PR in the meantime :)

@dvkch
Copy link
Author

dvkch commented Dec 15, 2022

Unfortunately I don't think i have the knowledge in Go to be able to help a lot on this, but i will definitely take a shot at it and keep you posted if i can help in any way !
Thank you for your answer 😊

@acouvreur
Copy link
Owner

acouvreur commented Mar 30, 2023

Just FYI, this was released in beta #134

You can try it out already using version 1.4.0-beta.1.

Thanks again for mentioning this, I think I will make it the default behavior from now on.

I will change all my doc from names to groups soon

@dvkch
Copy link
Author

dvkch commented Apr 4, 2023

This is amazing news! I currently don't have a setup that could make use of it anymore, but do plan on creating a new swarm, I will definitely keep you updated on how that goes using this 😊

@acouvreur acouvreur added enhancement New feature or request provider Issue related to a provider labels Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request provider Issue related to a provider
Projects
None yet
Development

No branches or pull requests

2 participants