Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use MaxBodySize value inside Modsecurity struct #10

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

acouvreur
Copy link
Owner

The MaxBodySize wasnt forwarded to the Modsecurity struct which uses its own MaxBodySize.

Something is still weird, its how the test was working,

@acouvreur acouvreur self-assigned this Aug 8, 2022
@acouvreur
Copy link
Owner Author

Oh its because in the tests, we initialize the Modsecurity struct

middleware := &Modsecurity{
next: httpServiceHandler,
modSecurityUrl: modsecurityMockServer.URL,
maxBodySize: 1024,
name: "modsecurity-middleware",
logger: log.New(io.Discard, "", log.LstdFlags),
}

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

🎉 This PR is included in version 1.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"body max limit reached: http: request body too large" since 1.2.0
1 participant